Update codex to 0.115.0 - #77
Closed
codex-acp-ci-app[bot] wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously failing tests and reasons:
ACP server test > should authenticate with keytimed out (40000ms) because the test still depended on real auth/session startup paths after the update, including an unresolvedawaitMcpServers()wait.ACP server test > should authenticate with a gatewaytimed out (40000ms) for the same reason: real session startup dependency and unresolved MCP startup wait.MCP session configuration > should return configured mcptimed out (40000ms) because session creation waited on MCP startup signals that were not guaranteed in this test flow.What I changed and why:
src/CodexEventHandler.tsto explicitly handle new notification variants introduced by regenerated app-server types (hook/*,item/autoApprovalReview/*,command/exec/outputDelta) as intentional no-op cases, so the switch is exhaustive and type-safe without a fallback.src/__tests__/CodexACPAgent/CodexAcpClient.test.tsto stub updated app-server auth/session methods (accountLogin,awaitLoginCompleted,threadStart,listModels,accountRead,awaitMcpServers, etc.), removing dependence on external login/network timing and making behavior deterministic.src/__tests__/CodexACPAgent/mcp-session.test.tsto mock post-update session dependencies (awaitMcpServers,threadStart,listModels,listMcpServerStatus, etc.) so/mcpassertion validates behavior instead of hanging on runtime startup conditions.src/__tests__/CodexACPAgent/data/auth-with-key.jsonto match the stabilized mocked post-update auth/session flow.